CS 134 lab submittal

  1. After you have passed all of your automated tests for a lab, you'll run: 
    make handin
    That'll double-check that you've passed your tests, and will also check to make sure all files have been committed, and that your local branch has been pushed to GitHub.
  2. Create a pull request on GitHub
    1. Go to Pull Request tab on GitHub
    2. Click on "New pull request".
    3. Select 'lab#-no-code' as the base branch and 'lab#' as the compare branch (where # is the lab number you just finished).
    4. Verify that the commits that are chosen are correct, and that the code that is shown as different is correct.
    5. Click on "Create pull request".
    6. In the right-hand column, click on the gear icon next to Reviewers
    7. Type "nrhodes-hmc" and click on the GitHub name in the list below.
    8. Click on "Create pull request".
  3. Wait for me to send back initial comments (my responses will be within 48 hours)
  4. Setup an Office Hours appointment with me that the entire team should join. We'll have a short (10-15 minutes) chat to discuss the code (ensures all members of the team understand all the code--jointly and severally liable). If I'm not satisfied that both team members understand all the code, I'll ask to meet again.
  5. We'll back and forth regading the code review.
  6. Every time you make changes and want me to re-review, you'll need to re-request a review! Otherwise, I won't get any notification and won't know to do the re-review.
  7. Once I'm satisfied, I'll approve the pull request.
  8. At that point, the team gets credit for having finished the lab.

All code reviews will stop 8AM, Monday, Nov. 30. Any Pull Requests not yet approved at that time will be abandoned).

If a student or team want to go back to do challenge problem(s) for a completed lab, they can. They'll just need to open a new pull request.

Notes

At most one Pull Request open per team. Team can still move forward on next lab while Pull Request is still open on previous lab.

However, once pull request is approved, changes from previous lab should be merged into the code of the next lab.

There are no fixed deadlines for the labs. However, these are time-consuming. Here's a target as to whether you are on track for finishing all of the labs (if you're behind these targets, you're in danger of failing to finish them all):

This is derivative work based on MIT 6.828 used under Creative Commons License.

Creative Commons License Top // CS 134 home // Last updated Mon Aug 31 05:15:06 PM PDT 2020